Possible error in itk::VectorContainer::End() function


(Johannes Keustermans) #1

Hi,

The current implementation of this function (the constant version) is as follows:
“return ConstIterator( this->VectorType::size() - 1, this->VectorType::end() );”
But should this not be
“return ConstIterator( this->VectorType::size(), this->VectorType::end() );”
As the end iterator is one past the last element in the container?
The same is true for the non-constant version.

Kind regards,
Johannes


(Dženan Zukić) #2

ITK’s image iterators have AtEnd() method, so this might be following that pattern. But it could very well be a bug. To determine that, classes which use VectorContainer should be examined. Also, there is no test for VectorContainer to quickly check how it is supposed to work. Is someone familiar with VectorContainer?