One example needs to be renamed (Create another instance of a filter?)

Community
1

Hi, may be you are already aware, but one of the examples may need to be renamed:

https://examples.itk.org/src/core/common/createanother/documentation

Its summary is “Copy/duplicate a filter”, so, I assume that it should be " “Create another instance of a filter”, because it’s next to Create Another Instance of an Image. Cheers, and thank you for ITK!

2 Likes
2

Thanks for the note. This is better entered as an issue in the repository. The best is to make a PR with the rename of the relevant files. If you also rename the directory, a rename in upper level CMakeLists.txt and index is needed too.

3

Dear @dzenanz,

I don’t have a Micro$oft GitHub account, but here is a patch (: . Thank you for showing me how to do it.
create_another_rename.diff (1.8 KB)

diff --git a/src/Core/Common/CMakeLists.txt b/src/Core/Common/CMakeLists.txt
index 5e2a0279..1ee5c76a 100644
--- a/src/Core/Common/CMakeLists.txt
+++ b/src/Core/Common/CMakeLists.txt
@@ -16,7 +16,7 @@ add_example(ObserveAnEvent)
 add_example(ComputeTimeBetweenPoints)
 add_example(WatchAFilter)
 add_example(IterateOnAVectorContainer)
-add_example(CreateAnother)
+add_example(CreateAnotherInstanceOfAFilter)
 add_example(CreateAFixedArray)
 add_example(AddOffsetToIndex)
 add_example(GetNameOfClass)
diff --git a/src/Core/Common/CreateAnother/CMakeLists.txt b/src/Core/Common/CreateAnotherInstanceOfAFilter/CMakeLists.txt
similarity index 100%
rename from src/Core/Common/CreateAnother/CMakeLists.txt
rename to src/Core/Common/CreateAnotherInstanceOfAFilter/CMakeLists.txt
diff --git a/src/Core/Common/CreateAnother/Code.cxx b/src/Core/Common/CreateAnotherInstanceOfAFilter/Code.cxx
similarity index 100%
rename from src/Core/Common/CreateAnother/Code.cxx
rename to src/Core/Common/CreateAnotherInstanceOfAFilter/Code.cxx
diff --git a/src/Core/Common/CreateAnother/Documentation.rst b/src/Core/Common/CreateAnotherInstanceOfAFilter/Documentation.rst
similarity index 100%
rename from src/Core/Common/CreateAnother/Documentation.rst
rename to src/Core/Common/CreateAnotherInstanceOfAFilter/Documentation.rst
diff --git a/src/Core/Common/index.rst b/src/Core/Common/index.rst
index e5919601..55e0818c 100644
--- a/src/Core/Common/index.rst
+++ b/src/Core/Common/index.rst
@@ -31,7 +31,7 @@ Common
   CreateAnImageRegion/Documentation.rst
   CreateAnImageOfVectors/Documentation.rst
   CreateAnRGBImage/Documentation.rst
-  CreateAnother/Documentation.rst
+  CreateAnotherInstanceOfAFilter/Documentation.rst
   CreateAnotherInstanceOfAnImage/Documentation.rst
   CreateDerivativeKernel/Documentation.rst
   CreateForwardDifferenceKernel/Documentation.rst
4

A bit more renames were needed. Here is the PR:

2 Likes
5

@Tom_Birdsong asks do you have an email address and/or full name you would like to have recorded in this PR?

1 Like
6

If a link to this discussion can be added, that would be better. Otherwise, I’m ok. Thanks for the consideration. (If I change my mind in the future, I will let you know for other contributions. Until then, you can always assume this answer).