Min and max required CMake versions being defined but not re-used

Engineering
1

Hi,
I’ve noticed that in the top-level CMakeLists.txt we are defining some min and max bounds for the required CMake versions, mainly labeled as having to do with CMake policies:
https://github.com/InsightSoftwareConsortium/ITK/blob/master/CMakeLists.txt#L14

I assume these min and max versions should apply to any project within ITK, including the third parties or remotes. Please correct me if I’m wrong.

A quick search of the cmake_minimum_required string provides:
https://github.com/search?q=repo%3AInsightSoftwareConsortium%2FITK%20cmake_minimum_required&type=code

That is, the variable defined in the top-level project is not used or propagated to othe CMakeLists.txt files within ITK.

Is there some reason for this? Am I missing something?

If it should be, I am happy to submit a PR.

Thanks.

2

I think that subdirectories inherit minimum version specification, so it is not needed to repeat it.

3

OK, not sure why we’ve been adding the command across different CMakeLists.txt files then.