Greptile

Engineering
1

I got an email from Greptile:

Greptile lets you add custom rules to enforce your organization’s preferences, coding standards and best practices automatically across pull requests.

You can configure them in two ways:
  1. .greptile/ Configuration: Individual teams can tailor settings, rules and context at the directory level in a .greptile/ folder.
  1. Greptile Dashboard: For quick experiments, or org wide defaults, you can add rules directly to the dashboard.

These patterns are optional and not required for high quality code reviews, but are recommended for orgs to create a tailored experience.

If someone wants to customize our Greptile bot, it is possible.

2 Likes
2

I am finding the flow charts are not useful enough to justify their size when scrolling.

1 Like
3

I made some setting changes through the web UI. I don’t know how quickly will these settings propagate. I also invited you and a few others as admins of Greptile organization.

1 Like
4

I very much agree! In general the output of Greptile appears too elaborate to me, especially for small pull requests. For example, the following PR just removed 9 lines of code, and added one line:

MarkovRandomFieldsClassifiers: Replace buffered region iteration in MRFImageFilter, remove iterator from RGBGibbsPriorFilter by N-Dekker · Pull Request #5977 · InsightSoftwareConsortium/ITK · GitHub

Still it got quite extensive feedback from Greptile!

More in general, the question is how we should deal with AI generated reviews. As a submitter of a PR, I hope that human reviewers keep focused on the actual code changes that I’m proposing, as well as the proposed commit messages. I hope that reviewers don’t get distracted by the amount of Greptile output.

1 Like
5

This PR has the long parts of Greptile reviews collapsed by default. So the changes I made to settings yesterday are having an effect.

6

Thanks @dzenanz

It’s good to be aware of the fact that AI reviews may themselves have flaws. I just noticed one in the flowchart generated by Greptile: Remove local type aliases of ImageRegionIterator and ImageRegionConstIterator in `*.hxx` files by N-Dekker · Pull Request #5981 · InsightSoftwareConsortium/ITK · GitHub

Also it appears to make mistakes when counting the number of (eliminated) variables of a pull request: Replace buffered region iteration with FillBuffer in FastMarching filters by N-Dekker · Pull Request #5970 · InsightSoftwareConsortium/ITK · GitHub

Should we report those errors to the makers of Greptile? At least we should be aware of such flaws.

1 Like
7

Give it a try, and see whether they are appreciative of the report.