GDCM Needs updating (20171120)

Engineering
, ,
1

CMake Deprecation Warning at Modules/ThirdParty/GDCM/src/gdcm/Utilities/socketxx/CMakeLists.txt:3 (cmake_policy):
The OLD behavior for policy CMP0022 will be removed from a future version
of CMake.

The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances. Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.

2

Fixing that does not seem hard - it is only for Socket++, and its CMakeLists is not big. I suppose this fix should be applied upstream and then GDCM simply updated? Is anyone familiar with GDCM contribution process?

3

@mathieu.malaterre @matt.mccormick @blowekamp @fbudin

4

@dzenanz Either send me a git-format-patch, or submit a PR on github: https://github.com/malaterre/GDCM/pulls.

Thanks

5

PR created:

6

The PR has been merged. @blowekamp @hjmjohnson We now just need to update our copy of GDCM.

7

I created a patch to Update GDCM:
http://review.source.kitware.com/#/c/22836/1

8

As @dzenanz pointed out in the patch that I created, GDCM has already been updated with this patch: http://review.source.kitware.com/#/c/22824/