Current Contributing.md missing PR step?


(Tobias Wood) #1

Hello,

I just pushed my first bug-fix to ITK via github instead of Gerrit. After I did a git review-push --force the branch was present in fork https://github.com/spinicist/ITK/tree/bug/bruker_int but I could not a PR in the consortium repo - so I pressed the “Create PR” button on Github.

Should the PR have been created automatically? Did I manage to mess up my local repo setup? It wouldn’t be the first time.


(Jon Haitz Legarreta Gorroño) #2

Hi Tobias,
short answer is no. The PRs still need to be created manually. But the moment you push, GitHub suggests you to open it.

Also, when you push a topic, the ITK git hooks suggest you to open a PR, providing the id of the PR, and the complete URL.

Thanks for contributing !

HTH.


(Matt McCormick) #3

@jhlegarreta is right – you did everything correctly. Congrats on your first pull request to the ITK GitHub repository! :octopus:

The patch modifies the CONTRIBUTING.md file so this is clear for future contributors:


(Jon Haitz Legarreta Gorroño) #4

Just to complete what has been said and the CONTRIBUTING.md guidelines, the ITK Git Sheet may be another useful resource when contributing.