Update Coding Style for ITK

jhlegarreta · November 4, 2020, 3:40pm

Maybe the immediately preceding comment lines:

// The following methods are used for updating the data processing pipeline.
//

//-------------------------------------------------------------

bear an impact on how the code is formatted/aligned in subsequent blocks?

Niels_Dekker · November 4, 2020, 3:50pm

In this specific case (the extra space before the ::MemberName), I agree that it isn’t worth using “clang-format off”, but thanks for the suggestion, Hans.

It seems to me that the space was introduced when the original source code had a line break instead. Like it was here ( DataObject ::Update in ITK 5.0.1):

github.com

InsightSoftwareConsortium/ITK/blob/v5.0.1/Modules/Core/Common/src/itkDataObject.cxx#L329


      
            os << indent << "UpdateMTime: " << m_UpdateMTime << std::endl;
            os << indent << "RealTimeStamp: " << m_RealTimeStamp << std::endl;
          }
          
          // The following methods are used for updating the data processing pipeline.
          //
          
          //----------------------------------------------------------------------------
          void
          DataObject
          ::Update()
          {
            this->UpdateOutputInformation();
            this->PropagateRequestedRegion();
            this->UpdateOutputData();
          }
          
          void
          DataObject
          ::UpdateOutputInformation()
          {

Interestingly, it appears to me that if you would manually remove those spaces, Clang-Format would not restore them!!! So it does look like a Clang-Format bug to me, indeed.

Niels_Dekker · November 4, 2020, 5:42pm

And if it is a bug in the Clang-Format version currently used by ITK (version 8.0.1), well… I just tried Clang-Format 11.0, and it still leaves those spaces there, between the class name and the ::MemberName!

Fortunately, Clang-Format does not appear to restore those spaces, when manually removed: