May we start using C++14 at the master branch?

seanm · June 2, 2021, 3:36pm

I’ve just checked all my bots, and most already specify -std=c++14 or -std=c++17, but one had -std=c++11, so I’ve updated that to 14. Let’s see how it does tomorrow…

dzenanz · June 3, 2021, 1:28pm

I just merged Niels’ patch!

Niels_Dekker · June 4, 2021, 12:34pm

@seanm Back in December 2019 ITK already required AppleClang 7.0.2 and later (from Xcode 7.2.1), as you committed:

From COMP: fixed compilation with AppleClang 7 and 8. by seanm · Pull Request #1464 · InsightSoftwareConsortium/ITK · GitHub

So do I understand correctly that AppleClang 5.1 + Xcode 5.1 have been dropped already before? Then maybe we should still adjust itkCompilerChecks.cmake:

github.com

InsightSoftwareConsortium/ITK/blob/c97530a44930d971d0c0b6b736ae5266066ecb27/CMake/itkCompilerChecks.cmake#L13-L17

    
      
          # Minimum compiler version check: Apple Clang >= 5.1 (Xcode 5.1)
          if (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND
              CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.1)
            message(FATAL_ERROR "Apple Clang 5.1 or later is required.")
          endif ()

seanm · June 7, 2021, 9:49pm

Niels, hmmm, not sure there was any great thought in that commit, it looks like previous to that AppleClang just wasn’t mentioned in that file. Personally, I’m ok with Xcode 7.2.1 being the minimum.

Niels_Dekker · June 9, 2021, 3:34pm

Thanks @seanm Do you mean that you actually still need to compile the latest ITK version on Xcode 7.2.1?