Image Registration with Pseudo-Random Sampling throws exception randomly (maybe bug)

HsuehWen · March 29, 2019, 2:01am

Just a report.
Exceptions were throw at trial 52203 & 52204.
Is there anything that I did wrong in building the code?

blowekamp · March 29, 2019, 1:26pm

Wow! That is running for quite a long time!

@matt.mccormick @dzenanz
I am going to take a guess that you are running into the problem of the time stamp overflowing.
It looks like it is still 32-bits on windows:

github.com

InsightSoftwareConsortium/ITK/blob/master/Modules/Core/Common/include/itkIntTypes.h#L104


using OffsetValueType = signed long;


#endif


/** Type to count and reference number of threads */
using ThreadIdType = unsigned int;


/** Type to count and reference the modification time of objects.
 * May in the future be replaced by SizeValueType to avoid overflows.
 */
using ModifiedTimeType = unsigned long;


}


#endif  /* itkIntTypes_h */

This should be fixed.

dzenanz · March 29, 2019, 1:43pm

I am giving it a try.

dzenanz · March 29, 2019, 2:57pm

Here is the PR:

HsuehWen · April 3, 2019, 2:07am

With the update, this test program can run up to trial 394000 now without any exception!
I’ll test on my original program and report the result.
Thank you so much @blowekamp @dzenanz !

By the way, I’m still using ITK version: 82dfa9ee752cdc240c46ded10242591dba97b21a
I have to update line 660, 669 of Modules\Core\SpatialObjects\include\itkSpatialObject.hxx
unsigned long -> ModifiedTimeType
or the build will fail

dzenanz · April 3, 2019, 2:20pm

Please update to the latest revision. If that still occurs, please submit a patch!

HsuehWen · April 8, 2019, 6:58am

I tried using the latest revision (a11cdfcd7feaeabaec5124b472f1f2a92d98b07e)
I can build the code but when I run my testing program, it throws lots of exception immediately

ExceptionObject caught !
itk::ExceptionObject (0000000E547FF6F0)
Location: “unknown”
File: c:\itk\modules\registration\metricsv4\include\itkCorrelationImageToImageMetricv4.hxx
Line: 75
Description: itk::ERROR: CorrelationImageToImageMetricv4(000001F7208A1A80): FixedSampledPointSet must have 1 or more points.

Am I using the correct revision?

dzenanz · April 8, 2019, 3:33pm

If you are using a fixed image mask, none of the randomly selected sample points fall inside the mask. You should increase number of sample points (increase sampling percentage).

HsuehWen · April 9, 2019, 2:22am

No, I don’t think that is the problem.
Using older version of ITK (like 82dfa9ee752cdc240c46ded10242591dba97b21a) is fine.
I’m wondering if a11cdfcd7feaeabaec5124b472f1f2a92d98b07e is a none stable version?
Or the interface has changed?
Or there might be bug?

dzenanz · April 9, 2019, 1:12pm

a11cdfcd7feaeabaec5124b472f1f2a92d98b07e is no more stable than 82dfa9ee752cdc240c46ded10242591dba97b21a. Both of those are recent commits on the master branch. There might be a bug introduced since 82dfa9e, or there is a bug in your program which only manifests itself with a11cdfc.