How to compile part of ITK integrated into another library?

dzenanz · February 3, 2021, 5:46pm

For this to be includable via this path, External\KWSys\src should be one of include_directories for ITK.

al-sabr · February 3, 2021, 5:47pm

Isn’t it automatically handled by KWSys? Where do I need to add if manually needed?

Is this what I am missing ?

InsightSoftwareConsortium/ITK/blob/5eb4697298b2cacaac6eef8f98858f6390246654/Modules/ThirdParty/KWSys/src/KWSys/CMakeLists.txt#L703


      
                  COMPILE_DEFINITIONS KWSYS_CXX_HAS_GETLOADAVG=1)
              endif()
            endif()
          endif()
          
          if(KWSYS_USE_FStream)
            KWSYS_PLATFORM_CXX_TEST(KWSYS_CXX_HAS_EXT_STDIO_FILEBUF_H
              "Checking whether <ext/stdio_filebuf.h> is available" DIRECT)
          endif()
          
          #-----------------------------------------------------------------------------
          # Choose a directory for the generated headers.
          if(NOT KWSYS_HEADER_ROOT)
            set(KWSYS_HEADER_ROOT "${PROJECT_BINARY_DIR}")
          endif()
          set(KWSYS_HEADER_DIR "${KWSYS_HEADER_ROOT}/${KWSYS_NAMESPACE}")
          include_directories(${KWSYS_HEADER_ROOT})
          
          #-----------------------------------------------------------------------------
          if(KWSYS_INSTALL_DOC_DIR)
            # Assign the license to the runtime component since it must be

al-sabr · February 3, 2021, 7:50pm

This seemed to clear the compilation error for KWSys:

But although VNL VCL are recognized by Visual Studio 2019 there’s still a compilation error.

dzenanz · February 3, 2021, 8:59pm

I think that vcl_compiler.h is generated during CMake configuration and placed in the build folder. You need to add it to include path.

al-sabr · February 3, 2021, 10:03pm

I kind of made it work but it is really an ugly hack. Let me explain!

Adding this target_link_libraries at : https://github.com/al-sabr/CTK/blob/8af983c5605c8b939c0eb8df35c0bfff54344a07/Libs/mbilog/CMakeLists.txt#L91

Allowed me to compile with mbilog + KWSys & VNL when I open the solution in VS2019 with successful compilation. The problem is the root CMakeLists.txt doesn’t compile anymore because of this added hack. Do you understand?

al-sabr · February 4, 2021, 1:16pm

This is how I overcame the compilation errors : Final compilation of mbilog successful. · al-sabr/CTK@d4059dd · GitHub

al-sabr · February 4, 2021, 1:50pm

This is the error I am getting with the root CMakeLists.txt :

1>CUSTOMBUILD : CMake error : install(EXPORT "CTKExports" ...) includes target "CTKmbilog" which requires target "itksys" that is not in any export set.
1>CUSTOMBUILD : CMake error : install(EXPORT "CTKExports" ...) includes target "CTKmbilog" which requires target "itkvnl" that is not in any export set.
1>CUSTOMBUILD : CMake error : install(EXPORT "CTKExports" ...) includes target "CTKmbilog" which requires target "itkvcl" that is not in any export set.

How can I include those external dependencies so that it is recognized inside of my build system?
They are although compiling …

dzenanz · February 4, 2021, 2:52pm

You need to export itksys, itkvnl and itkvcl in their respective CMakeLists.

al-sabr · February 4, 2021, 4:19pm

Why isn’t this already handled automatically by ITK ?

dzenanz · February 4, 2021, 5:30pm

Because you only took part of ITK.

al-sabr · February 4, 2021, 8:56pm

Hehe makes sense! And which part of ITK integrates KWSys & VNL? I would like to learn that part because I don’t fully grasp CMake in its entirety.

dzenanz · February 4, 2021, 9:23pm

You probably want to take this part of code for VNL:

github.com

InsightSoftwareConsortium/ITK/blob/v5.2rc01/Modules/ThirdParty/VNL/CMakeLists.txt#L7-L22


if(ITK_USE_SYSTEM_VXL)
  find_package(VXL 3.0.0 REQUIRED)
  # 3.0.0 is the first version of VXL that supports
  # the requirement of front() and back() members
  # in the vnl_vector and vnl_vector_fixed.
  set(ITKVNL_SYSTEM_INCLUDE_DIRS
    ${VXL_NETLIB_INCLUDE_DIR}
    ${VXL_VCL_INCLUDE_DIRS}
    ${VXL_VCL_INCLUDE_DIR}
    ${VXL_CORE_INCLUDE_DIRS}
    ${VXL_CORE_INCLUDE_DIR}
    )
  set(ITKVNL_LIBRARIES vnl_algo vnl v3p_netlib netlib vcl)
  set(ITKVNL_SYSTEM_LIBRARY_DIRS "${VXL_LIBRARY_DIR}")
  set(ITKVNL_NO_SRC 1)
else()

and for KWSys some or all of CMake code from

github.com

InsightSoftwareConsortium/ITK/blob/v5.2rc01/Modules/ThirdParty/KWSys/CMakeLists.txt

project(ITKKWSys)
set(ITKKWSys_THIRD_PARTY 1)

set(KWSYS_HEADER_ROOT ${ITKKWSys_BINARY_DIR}/src)
set(ITKKWSys_INCLUDE_DIRS
  ${KWSYS_HEADER_ROOT}
  )
set(ITKKWSys_LIBRARIES itksys)

# Use Unicode instead of ASCII by default
set(KWSYS_ENCODING_DEFAULT_CODEPAGE CP_UTF8)

itk_module_impl()

and

github.com

InsightSoftwareConsortium/ITK/blob/v5.2rc01/Modules/ThirdParty/KWSys/src/CMakeLists.txt

set(KWSYS_NAMESPACE itksys)
set(KWSYS_USE_SystemTools 1)
set(KWSYS_USE_RegularExpression 1)
set(KWSYS_USE_Directory 1)
set(KWSYS_USE_Base64 1)
set(KWSYS_USE_MD5 1 )
set(KWSYS_USE_CommandLineArguments 1)
set(KWSYS_USE_Process 1)
if(ITK_DYNAMIC_LOADING)
  set(KWSYS_USE_DynamicLoader 1)
else()
  set(KWSYS_USE_DynamicLoader 0)
endif()
set(KWSYS_USE_Glob 1)
set(KWSYS_USE_Registry 1)
set(KWSYS_USE_SystemInformation 1)
set(KWSYS_INSTALL_INCLUDE_DIR ${ITKKWSys_INSTALL_INCLUDE_DIR})
set(KWSYS_INSTALL_LIB_DIR ${ITKKWSys_INSTALL_LIBRARY_DIR})
set(KWSYS_INSTALL_BIN_DIR ${ITKKWSys_INSTALL_RUNTIME_DIR})
set(KWSYS_INSTALL_DOC_DIR ${ITK_INSTALL_DOC_DIR})

This file has been truncated. show original

al-sabr · February 5, 2021, 4:10pm

Isn’t it this which is already there ?

https://github.com/al-sabr/CTK/blob/ctk-blueberry-port-from-mitk/External/VNL/CMakeLists.txt

https://github.com/al-sabr/CTK/blob/ctk-blueberry-port-from-mitk/External/KWSys/src/CMakeLists.txt

https://github.com/al-sabr/CTK/blob/ctk-blueberry-port-from-mitk/External/KWSys/src/KWSys/CMakeLists.txt

All of these are included here : CTK/CMakeLists.txt at 226ce09057fc5c66654d868e079761316a60f7ad · al-sabr/CTK · GitHub

dzenanz · February 5, 2021, 4:25pm

You need to remove this conditional, use add_subdirectory instead of find_package. Maybe something similar for KWSys.

al-sabr · February 5, 2021, 4:26pm

It is already like you suggested CTK/CMakeLists.txt at 226ce09057fc5c66654d868e079761316a60f7ad · al-sabr/CTK · GitHub

dzenanz · February 5, 2021, 4:28pm

But you need the additional code for linking:

  set(ITKVNL_SYSTEM_INCLUDE_DIRS
    ${VXL_NETLIB_INCLUDE_DIR}
    ${VXL_VCL_INCLUDE_DIRS}
    ${VXL_VCL_INCLUDE_DIR}
    ${VXL_CORE_INCLUDE_DIRS}
    ${VXL_CORE_INCLUDE_DIR}
    )
  set(ITKVNL_LIBRARIES vnl_algo vnl v3p_netlib netlib vcl)
  set(ITKVNL_SYSTEM_LIBRARY_DIRS "${VXL_LIBRARY_DIR}")

You might also need to modify it.

al-sabr · February 5, 2021, 4:45pm

Actually in my CMake window I didn’t check the ITK_USE_SYSTEM_VXL so it by pass that condition.

al-sabr · February 5, 2021, 5:14pm

@dzenanz We were complicating everything up until now … the trick was this :

Although everything seems to be fine with the includes VNL is recognized but not KWSys why do you have an idea?

al-sabr · February 5, 2021, 7:23pm

@dzenanz it seems that adding this line : https://github.com/al-sabr/CTK/blob/36f04e0c5a69162422c5fe86c66d808013bae28d/Libs/mbilog/CMakeLists.txt#L91

Make the compilation goes through but adding it here : https://github.com/al-sabr/CTK/blob/36f04e0c5a69162422c5fe86c66d808013bae28d/Libs/mbilog/target_libraries.cmake#L9

Doesn’t recognize it… is there any bug in KWSys structure?

dzenanz · February 5, 2021, 7:48pm

Since you are changing a lot of defines and directory structure, you might need to change #include "itksys/Directory.h into #include "KWSys/Directory.h or just #include "Directory.h.