# GDCM Needs updating (20171120)

**URL:** <https://discourse.itk.org/t/gdcm-needs-updating-20171120/439>\
**Category:** Engineering\
**Tags:** dicom, build, cmake\
**Created:** [November 21, 2017, 1:04am UTC](https://discourse.itk.org/t/gdcm-needs-updating-20171120/439 "2017-11-21T01:04:22Z")\
**Posts on this page:** 8\
**Page:** 1

<div class="post-metadata">

**Author:** ![hjmjohnson](https://discourse.itk.org/user_avatar/discourse.itk.org/hjmjohnson/32/23_2.png) [@hjmjohnson](https://discourse.itk.org/u/hjmjohnson)\
**Post date:** [November 21, 2017, 1:04am UTC](https://discourse.itk.org/t/gdcm-needs-updating-20171120/439/1 "2017-11-21T01:04:23Z")

</div>

CMake Deprecation Warning at Modules/ThirdParty/GDCM/src/gdcm/Utilities/socketxx/CMakeLists.txt:3 (cmake\_policy):  
The OLD behavior for policy CMP0022 will be removed from a future version  
of CMake.

The cmake-policies(7) manual explains that the OLD behaviors of all  
policies are deprecated and that a policy should be set to OLD only under  
specific short-term circumstances. Projects should be ported to the NEW  
behavior and not rely on setting a policy to OLD.

---

<div class="post-metadata">

**Author:** ![dzenanz](https://discourse.itk.org/user_avatar/discourse.itk.org/dzenanz/32/1093_2.png) [@dzenanz](https://discourse.itk.org/u/dzenanz)\
**Post date:** [November 21, 2017, 3:47pm UTC](https://discourse.itk.org/t/gdcm-needs-updating-20171120/439/2 "2017-11-21T15:47:33Z")

</div>

Fixing that does not seem hard - it is only for Socket++, and its CMakeLists is not big. I suppose this fix should be applied upstream and then GDCM simply updated? Is anyone familiar with GDCM contribution process?

---

<div class="post-metadata">

**Author:** ![dzenanz](https://discourse.itk.org/user_avatar/discourse.itk.org/dzenanz/32/1093_2.png) [@dzenanz](https://discourse.itk.org/u/dzenanz)\
**Post date:** [November 21, 2017, 4:07pm UTC](https://discourse.itk.org/t/gdcm-needs-updating-20171120/439/3 "2017-11-21T16:07:47Z")

</div>

@mathieu.malaterre @matt.mccormick @blowekamp @fbudin

---

<div class="post-metadata">

**Author:** ![mathieu.malaterre](https://discourse.itk.org/user_avatar/discourse.itk.org/mathieu.malaterre/32/205_2.png) [@mathieu.malaterre](https://discourse.itk.org/u/mathieu.malaterre)\
**Post date:** [November 22, 2017, 6:55am UTC](https://discourse.itk.org/t/gdcm-needs-updating-20171120/439/4 "2017-11-22T06:55:32Z")

</div>

@dzenanz Either send me a git-format-patch, or submit a PR on github: [https://github.com/malaterre/GDCM/pulls](https://github.com/malaterre/GDCM/pulls).

Thanks

---

<div class="post-metadata">

**Author:** ![dzenanz](https://discourse.itk.org/user_avatar/discourse.itk.org/dzenanz/32/1093_2.png) [@dzenanz](https://discourse.itk.org/u/dzenanz)\
**Post date:** [November 22, 2017, 3:06pm UTC](https://discourse.itk.org/t/gdcm-needs-updating-20171120/439/5 "2017-11-22T15:06:45Z")

</div>

PR created:

> <https://github.com/malaterre/GDCM/pull/39>

---

<div class="post-metadata">

**Author:** ![dzenanz](https://discourse.itk.org/user_avatar/discourse.itk.org/dzenanz/32/1093_2.png) [@dzenanz](https://discourse.itk.org/u/dzenanz)\
**Post date:** [November 23, 2017, 2:58pm UTC](https://discourse.itk.org/t/gdcm-needs-updating-20171120/439/6 "2017-11-23T14:58:46Z")

</div>

The PR has been merged. @blowekamp @hjmjohnson We now just need to update our copy of GDCM.

---

<div class="post-metadata">

**Author:** ![fbudin](https://discourse.itk.org/user_avatar/discourse.itk.org/fbudin/32/14_2.png) [@fbudin](https://discourse.itk.org/u/fbudin)\
**Post date:** [November 29, 2017, 11:58pm UTC](https://discourse.itk.org/t/gdcm-needs-updating-20171120/439/7 "2017-11-29T23:58:52Z")

</div>

I created a patch to Update GDCM:  
[http://review.source.kitware.com/#/c/22836/1](http://review.source.kitware.com/#/c/22836/1)

---

<div class="post-metadata">

**Author:** ![fbudin](https://discourse.itk.org/user_avatar/discourse.itk.org/fbudin/32/14_2.png) [@fbudin](https://discourse.itk.org/u/fbudin)\
**Post date:** [December 1, 2017, 2:00pm UTC](https://discourse.itk.org/t/gdcm-needs-updating-20171120/439/8 "2017-12-01T14:00:17Z")

</div>

As @dzenanz pointed out in the patch that I created, GDCM has already been updated with this patch: [http://review.source.kitware.com/#/c/22824/](http://review.source.kitware.com/#/c/22824/)
